-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dht): use new DHKE shared secret type #4844
Merged
stringhandler
merged 7 commits into
tari-project:development
from
AaronFeickert:zeroize-shared-secrets
Nov 7, 2022
Merged
fix(dht): use new DHKE shared secret type #4844
stringhandler
merged 7 commits into
tari-project:development
from
AaronFeickert:zeroize-shared-secrets
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
changed the title
fix[dht]: zeroize ECDH secret
fix(dht): zeroize ECDH secret
Oct 21, 2022
CjS77
added
P-acks_required
Process - Requires more ACKs or utACKs
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
labels
Oct 21, 2022
sdbondi
reviewed
Oct 24, 2022
sdbondi
previously approved these changes
Oct 24, 2022
CjS77
removed
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Oct 24, 2022
ACK |
AaronFeickert
changed the title
fix(dht): zeroize ECDH secret
fix(dht): use new DHKE shared secret type
Oct 24, 2022
CjS77
added
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Oct 24, 2022
stringhandler
previously approved these changes
Oct 25, 2022
CjS77
removed
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Oct 25, 2022
utACK |
CjS77
added
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Oct 27, 2022
Now updates |
AaronFeickert
force-pushed
the
zeroize-shared-secrets
branch
2 times, most recently
from
October 27, 2022 22:12
50eeff5
to
667757e
Compare
This is currently blocked on |
@AaronFeickert Try adding the tari_crypto/wasm feature
- wasm = ["wasm-bindgen", "js", "tari_common_types", "console_error_panic_hook"]
+ wasm = ["tari_crypto/wasm", "wasm-bindgen", "js", "tari_common_types", "console_error_panic_hook"] |
AaronFeickert
force-pushed
the
zeroize-shared-secrets
branch
from
November 1, 2022 21:01
0524016
to
cbf0057
Compare
stringhandler
added
the
W-network-breaking
Warn - Contains changes that will not work with existing nodes on a network level
label
Nov 7, 2022
I had confused this with another issue. This is not network breaking |
stringhandler
removed
the
W-network-breaking
Warn - Contains changes that will not work with existing nodes on a network level
label
Nov 7, 2022
sdbondi
approved these changes
Nov 7, 2022
CjS77
removed
the
P-reviews_required
Process - Requires a review from a lead maintainer to be merged
label
Nov 7, 2022
stringhandler
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures safer use of ECDH shared secrets by switching to the new
DiffieHellmanSharedSecret
type. Updatestari-crypto
to v0.15.7 to accomplish this.Motivation and Context
Currently, an ECDH secret used for message keys is produced as a
RistrettoPublicKey
, converted to bytes, and returned as a byte array. However, neither theRistrettoPublicKey
nor the byte array are cleared when dropped. In conjunction withtari-crypto
PR 137, this work ensures both theRistrettoPublicKey
and byte array representations of the ECDH secret are zeroized on drop by using that PR's newDiffieHellmanSharedSecret
type.How Has This Been Tested?
Tested after applying
tari-crypto
PR 137, which adds the newDiffieHellmanSharedSecret
generic type.