Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude libtor from windows build #4631

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Sep 7, 2022

Description

Motivation and Context

How Has This Been Tested?

@sdbondi sdbondi marked this pull request as draft September 7, 2022 10:34
@delta1
Copy link
Contributor

delta1 commented Sep 7, 2022

lol for devs on windows

@sdbondi
Copy link
Member Author

sdbondi commented Sep 7, 2022

libtor isnt built on windows

@sdbondi sdbondi force-pushed the build-matrix-exclude-flags branch 6 times, most recently from 3b027b2 to 962666c Compare September 7, 2022 14:58
@sdbondi sdbondi marked this pull request as ready for review September 7, 2022 14:58
@sdbondi sdbondi force-pushed the build-matrix-exclude-flags branch 2 times, most recently from 31677ca to 9babc9e Compare September 7, 2022 15:43
@sdbondi sdbondi force-pushed the build-matrix-exclude-flags branch from 9babc9e to 3d73ae0 Compare September 7, 2022 16:46
@sdbondi
Copy link
Member Author

sdbondi commented Sep 7, 2022

Matrix builds passing https://github.com/sdbondi/tari/actions/runs/3008941799

@AaronFeickert
Copy link
Collaborator

Fixes cargo check on my local Linux machine too.

@stringhandler stringhandler merged commit dffea23 into tari-project:development Sep 8, 2022
@sdbondi sdbondi deleted the build-matrix-exclude-flags branch September 8, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants