Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console-wallet): detect local base node and prompt #4557

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 29, 2022

Description

Auto-detects base node grpc on console wallet startup and prompts to use it

Motivation and Context

Resolves #4414

Behaviour:

  • if custom base node is set in the config, dont prompt
  • if non interactive mode, dont prompt
  • if custom base node in the database is already set to detected base node, dont prompt

How Has This Been Tested?

Manually, no base node set, startup with and without base node grpc available

@sdbondi sdbondi force-pushed the wallet-auto-configure-local-base-node branch from ce3e4a5 to 6b95253 Compare August 29, 2022 09:07
@stringhandler stringhandler merged commit 887df88 into tari-project:development Aug 29, 2022
@sdbondi sdbondi deleted the wallet-auto-configure-local-base-node branch August 29, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet should detect local base nodes and automatically use them unless configured not to
2 participants