fix!: header consensus

[SWvheerden]

Description

Fix header consensus encoding

How Has This Been Tested?

[sdbondi]

You'll also need to update the tari_miner_helper consensus change test.

Bonus: change the consensus decoding code

// From this
FixedHash::from(<[u8; 32] as ConsensusDecoding>::consensus_decode(reader)?);
// to this
FixedHash::consensus_decode(reader)?;

[SWvheerden]

Thanks,
but no, tari_miner_helper consensus change test is correct as of #4522

[sdbondi]

I suggest adding a test for header consensus encoding

#[test]
fn consensus_encoding() {
 let consensus_constants = ConsensusConstantsBuilder::new(Network::Esmeralda)
        .build();
   let header = BlockHeader::new(consensus_constants.blockchain_version);
   check_consensus_encoding_correctness(header).unwrap();
}

[SWvheerden]

I suggest adding a test for header consensus encoding

#[test]
fn consensus_encoding() {
 let consensus_constants = ConsensusConstantsBuilder::new(Network::Esmeralda)
        .build();
   let header = BlockHeader::new(consensus_constants.blockchain_version);
   check_consensus_encoding_correctness(header).unwrap();
}

yeah, will add one in the next pr

[hansieodendaal]

Thanks, these slipped me by with the latest commit in #4522