Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[comms] Enforce maximum RPC sessions per peer #4497

Closed
SWvheerden opened this issue Aug 18, 2022 · 0 comments · Fixed by #4549
Closed

[comms] Enforce maximum RPC sessions per peer #4497

SWvheerden opened this issue Aug 18, 2022 · 0 comments · Fixed by #4549
Assignees
@sdbondi

Comments

@SWvheerden
Copy link
Collaborator

Currently any node can block new RPC connections on another node by taking up the max global RPC connections (default: 1000).

We need the change the RPC to have a total maximum RPC connections and a maximum per peer.
@SWvheerden SWvheerden moved this to Todo in Tari Esme Testnet Aug 18, 2022
@sdbondi sdbondi moved this from Todo to In Progress in Tari Esme Testnet Aug 26, 2022
@sdbondi sdbondi self-assigned this Aug 26, 2022
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 26, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
923304c
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 26, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
749468e
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 26, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
1879702
@sdbondi sdbondi mentioned this issue Aug 26, 2022
Merged
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 26, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
a19b209
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 26, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
5af76ea
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 26, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
51aa14a
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 29, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
cc91c5f
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 29, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
f95fa38
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 29, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
2cf153b
sdbondi added a commit to sdbondi/tari that referenced this issue Aug 29, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer tari-project#4497
1c12701
stringhandler pushed a commit that referenced this issue Aug 29, 2022
@sdbondi
feat(comms/rpc): restrict rpc session per peer #4497 (#4549)
080bccf 
Description
---
- restrict the max number of active rpc sessions per peer

Motivation and Context
---
fixes #4497 

How Has This Been Tested?
---
Additional unit tests
Repository owner moved this from In Progress to Done in Tari Esme Testnet Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdbondi sdbondi

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(comms/rpc): restrict rpc session per peer #4497 sdbondi/tari
2 participants
@sdbondi @SWvheerden