fix: add hashing api on comms repo (see issue #4393) #4429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
approved these changes
Aug 10, 2022
| @@ -136,9 +138,9 @@ impl IdentitySignature { | |||
| features: PeerFeatures, | |||
| addresses: I, | |||
| updated_at: DateTime<Utc>, | |||
| ) -> CommsChallenge { | |||
| ) -> DomainSeparatedHasher<CommsChallenge, CommsCorePeerManagerDomain> { | |||
There was a problem hiding this comment.
nit: I think we can return a [u8;32] out here - not sure why I returned the CommsChallenge type
sdbondi
reviewed
Aug 10, 2022
|
|
||
| hash_domain!( | ||
| CommsCorePeerManagerDomain, | ||
| "com.tari.tari_project.comms.core.peer_manager", |
There was a problem hiding this comment.
Suggested change
| "com.tari.tari_project.comms.core.peer_manager", | |
| "com.tari.comms.core.peer_manager", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--- Add use of hashing API on repo
comms.Motivation and Context
--- Tackle issue #4393
How Has This Been Tested?
--- Unit tests