feat(base_layer): checkpoint quorum validation #4303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the base layer committee validation for checkpoints:
HashSet
of VNC public keys: one for the constitution and other for the checkpointmutable_key_type
for usingPublicKey
types as the keys in theHashSet
. I'm not sure where the mutability comes from. I decided to ignore that rule for the validation functionMotivation and Context
The base layer need to validate if the quorum of an incoming checkpoint is met. The minimum quorum for checkpoints is specified in the
ContractConstitution
, in thecheckpoint_params.minimum_quorum_required field
How Has This Been Tested?
New unit test to check both successful and failing scenarios regarding quorum conditions