feat(wallet_ffi): wallet_get_utxos, wallet_coin_join, wallet_coin_split #4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFI join & split functionality + tests rewrote coin_split function fixed TariVector conversion bug found a problem in the coin_join approach, need reconsideration this commit is for review only before the final brushing/wrap-up adding TariVector to substitute TariOutputs et al (WIP) added coin join + initial unit test (still WIP) added an output database shortcut for easier access from the wallet context, circumventing hops through async fall-through constructs; updated all usages - `cargo test` passing. added FFI `wallet_get_utxos()`, `destroy_tari_outputs` + unit test added a simple output querying function Signed-off-by: Andrei Gubarev <[email protected]>
agubarev
force-pushed
the
testnet-dibbler
branch
from
d474e14
to
ffa4102
Compare
FFI join & split functionality + tests rewrote coin_split function fixed TariVector conversion bug found a problem in the coin_join approach, need reconsideration this commit is for review only before the final brushing/wrap-up adding TariVector to substitute TariOutputs et al (WIP) added coin join + initial unit test (still WIP) added an output database shortcut for easier access from the wallet context, circumventing hops through async fall-through constructs; updated all usages - `cargo test` passing. added FFI `wallet_get_utxos()`, `destroy_tari_outputs` + unit test added a simple output querying function Signed-off-by: Andrei Gubarev <[email protected]>
FFI join & split functionality + tests rewrote coin_split function fixed TariVector conversion bug found a problem in the coin_join approach, need reconsideration this commit is for review only before the final brushing/wrap-up adding TariVector to substitute TariOutputs et al (WIP) added coin join + initial unit test (still WIP) added an output database shortcut for easier access from the wallet context, circumventing hops through async fall-through constructs; updated all usages - `cargo test` passing. added FFI `wallet_get_utxos()`, `destroy_tari_outputs` + unit test added a simple output querying function Signed-off-by: Andrei Gubarev <[email protected]>
…bbler # Conflicts: # base_layer/wallet/src/output_manager_service/service.rs # base_layer/wallet_ffi/src/lib.rs
FFI join & split functionality + tests rewrote coin_split function fixed TariVector conversion bug found a problem in the coin_join approach, need reconsideration this commit is for review only before the final brushing/wrap-up adding TariVector to substitute TariOutputs et al (WIP) added coin join + initial unit test (still WIP) added an output database shortcut for easier access from the wallet context, circumventing hops through async fall-through constructs; updated all usages - `cargo test` passing. added FFI `wallet_get_utxos()`, `destroy_tari_outputs` + unit test added a simple output querying function Signed-off-by: Andrei Gubarev <[email protected]>
agubarev
changed the title
stringhandler
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFI join & split functionality + tests
rewrote coin_split function
fixed TariVector conversion bug
found a problem in the coin_join approach, need reconsideration
this commit is for review only before the final brushing/wrap-up
adding TariVector to substitute TariOutputs et al (WIP)
added coin join + initial unit test (still WIP)
added an output database shortcut for easier access from the wallet context, circumventing hops through async fall-through constructs; updated all usages -
cargo testpassing.added FFI
wallet_get_utxos(),destroy_tari_outputs+ unit testadded a simple output querying function