feat(vn): record contract states #4241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The long sleep length was causing the specs to fail. We also don't want to wait in minutes for polling to occur. Make the option configurable and use a much shorter time in testing.
brianp
changed the title
brianp
force-pushed
the
record-accepted-constitutions
branch
from
d2ed829
to
bb3d2a3
Compare
stringhandler
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a contracts table to the global vn db so we can store the state of contracts the vn is a member of.
Motivation and Context
It will make it easier to go back and check known contracts that are awaiting quorum acceptance.
How Has This Been Tested?
Manually, and by fixing the previously broken spec.