feat(wallet): allow UTXO selection by specific outputs and by token #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
wallet-input-selection
branch
from
b1f3ee1
to
9b593eb
Compare
stringhandler
approved these changes
Jun 23, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jun 23, 2022
* testnet-dibbler: feat(wallet): allow UTXO selection by specific outputs and by token (tari-project#4227) feat(ci): build both x86/arm64 docker images from GHA (tari-project#4204)
stringhandler
pushed a commit
that referenced
this pull request
Nov 7, 2022
…issue #4811] (#4854) Description --- Added UtxoSelectionMode to enable output listing, unrestricted by `script_lock_height` or `maturity`, it has two modes at the moment: `Safe` and `ListingOnly`: - `Safe` is supposed to be used when payment is expected, - `ListingOnly` is to have an option to view existing outputs e.g., to see received, but yet to be matured outputs. And brushed up a little for easier readability. Motivation and Context --- Under certain conditions the function select_utxos selects utxo's which it cannot spend yet due to the timelocks. Since PR #4227, the wallet can under certain conditions (not default) select UTXOs that have not yet been matured. The Wallet should ALWAYS look to only select utxos that have matured on script_lock_height and maturity #4811 How Has This Been Tested? --- existing unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UtxoSelectionCriteria::TokenOutputsto allow db-level filtering for unique_idUtxoSelectionCriteria::SpecificOutputsto allow spendin specific utxosMotivation and Context
The previous logic of UTXO selection has been kept equivalent (no utxo selection tests needed to be changed), but extended to allow Tokens and specific UTXOs to be selected at the db-level
UtxoSelectionCriteria::TokenOutputsdoes db-level querying which is more performant, and will be chaned on development branch to ContractOutputs (so was worth doing)How Has This Been Tested?
Existing tests for coin split and utxo selection
Manually, running soin split and make it rain