fix(core): cleanup duplicate maturity check #4181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up duplicate maturity check introduced in #4168
Motivation and Context
In PR #4168 I renamed
check_coinbase_rewardtocheck_coinbasebut then decided that sincecheck_coinbasedoesn't fully check the coinbase, to split the checks intocheck_coinbase_rewardandcheck_coinbase_maturity- however I forgot to take the code out ofcheck_coinbase_reward.Duplicated code
How Has This Been Tested?
More tests are needed