feat: add an encrypted value to the TransactionOutput #4148
Conversation
therustmonk
force-pushed
the
transaction-output-encrypted-value
branch
5 times, most recently
from
3b6da02
to
43624b2
Compare
| impl ConsensusEncoding for EncryptedValue { | ||
| fn consensus_encode<W: Write>(&self, writer: &mut W) -> Result<(), io::Error> { | ||
| self.data.consensus_encode(writer)?; | ||
| self.0.consensus_encode(writer)?; | ||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| impl ConsensusDecoding for EncryptedValue { | ||
| fn consensus_decode<R: Read>(reader: &mut R) -> Result<Self, io::Error> { | ||
| let data = <[u8; 24]>::consensus_decode(reader)?; | ||
| Ok(Self { data }) | ||
| Ok(Self(data)) | ||
| } | ||
| } |
There was a problem hiding this comment.
I think a test would be in order for the encoding/decoding
| } | ||
| /// value: u64 + tag: [u8; 16] | ||
| #[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq, Hash)] | ||
| pub struct EncryptedValue(#[serde(with = "hex::serde")] pub [u8; SIZE]); |
There was a problem hiding this comment.
Any reason we use hex to serialize this value?
This essentially doubles the storage required to 48 bytes.
You could implement the Hex trait from tari_utilities if you want to convert this value to and from hex
There was a problem hiding this comment.
I've added hex support to read values from the dibbler_faucet.json file. Ok, I'll try to make it more coherently with other types we use in the TransactionOutput.
There was a problem hiding this comment.
👍 I think you may need serialize_with, something like this https://stackoverflow.com/a/67148611/1077579
Essentially, using hex only when the serialisation is "human readable"
therustmonk
force-pushed
the
transaction-output-encrypted-value
branch
from
43624b2
to
def1a7f
Compare
| @@ -0,0 +1,105 @@ | |||
| use std::{fmt, marker::PhantomData}; | |||
There was a problem hiding this comment.
The licence text is missing here
There was a problem hiding this comment.
Moved and fixed here: tari-project/tari_utilities#43
| @@ -57,6 +57,7 @@ mod committee_definition_features; | |||
| mod encrypted_value; | |||
| mod error; | |||
| mod full_rewind_result; | |||
| mod hex_patch; | |||
There was a problem hiding this comment.
Where is this used? Maybe it should move to tari_utilities?
There was a problem hiding this comment.
Yeah, I did that: tari-project/tari_utilities#43
therustmonk
force-pushed
the
transaction-output-encrypted-value
branch
4 times, most recently
from
bd0723e
to
3aa0c04
Compare
therustmonk
force-pushed
the
transaction-output-encrypted-value
branch
2 times, most recently
from
110a5fc
to
cfdbf6b
Compare
therustmonk
force-pushed
the
transaction-output-encrypted-value
branch
from
cfdbf6b
to
8490aea
Compare
- Added FFI methods to for the encrypted value - Fixed the failing unit test - Added new FFI tests
feat: add ffi methods
| /// that will produce a decrypted value from self. | ||
| pub fn todo_decrypt(&self) -> u64 { | ||
| let mut buffer = [0u8; 8]; | ||
| (&mut buffer[0..8]).copy_from_slice(&self.0.as_slice()[0..8]); |
There was a problem hiding this comment.
| (&mut buffer[0..8]).copy_from_slice(&self.0.as_slice()[0..8]); | |
| buffer[0..8].copy_from_slice(&self.0[0..8]); |
* development: feat(wallet): new cli commands to initialise proposals and amendments (tari-project#4205) feat: add an encrypted value to the TransactionOutput (tari-project#4148) feat: use tari_crypto's updated "extended pedersen commitment factory" (tari-project#4206)
Description
The PR adds the
encrypted_valuefield (ofEncryptedValuetype) to theTransactionOutputstruct.The same field also added to the
TransactionInputfor a case when input was produced from an output.The changes also affected the genesis block, dibbler's faucet data, hashes and integration tests.
The value is not actually encrypted and now it's stored in the following format: u64le + 16 empty bytes.
Motivation and Context
Part of the BP+ features.
How Has This Been Tested?
CI tests (updated)