Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daily-tests): use environment variable to set custom seed words #4086

Merged
merged 2 commits into from
May 25, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented May 9, 2022

Description

Allow custom seed words to be set for wallet recovery daily test by setting the WALLET_RECOVERY_SEED_WORDS environment variable.

Motivation and Context

Whenever the seed words in daily tests need to change, a code change is needed. The seed words should be configurable. The current hardcoded seed words are the default.

How Has This Been Tested?

SWvheerden
SWvheerden previously approved these changes May 10, 2022
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Untested

@stringhandler stringhandler changed the base branch from development to testnet-dibbler May 25, 2022 12:17
@stringhandler stringhandler dismissed SWvheerden’s stale review May 25, 2022 12:17

The base branch was changed.

@aviator-app aviator-app bot merged commit 3773bba into tari-project:testnet-dibbler May 25, 2022
@sdbondi sdbondi deleted the cron-env-seed-words branch May 25, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants