fix(comms)!: commit to public key and nonce in identity sig #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-identity-signature-security
branch
2 times, most recently
from
a8fb156
to
0dbdc2c
Compare
sdbondi
force-pushed
the
comms-identity-signature-security
branch
from
0dbdc2c
to
7ed0a86
Compare
* development: (32 commits) chore(deps): bump ejs from 3.1.6 to 3.1.7 in /applications/tari_collectibles/web-app (tari-project#4057) chore: remove deprecated ExtendBytes, update EpochTime (tari-project#3914) ci: fix coverage (tari-project#4071) feat(p2p): adds tor.forward_address setting (tari-project#4070) fix(key-manager): remove floating point math from mnemonic code (tari-project#4064) test(cucumber): use separate FFI target dir (tari-project#4067) refactor(comms): reduce length of long functions (clippy) (tari-project#4065) fix: update daily test configuration (tari-project#4049) refactor(rpc-macros): split into smaller functions (clippy) (tari-project#4063) refactor(dht): use CipherKey new type for diffie-hellman key (tari-project#4038) docs(comms): adds documentation for comms public interface (tari-project#4033) fix: only count base nodes in peers count in base node status (tari-project#4039) docs: add key manager docs (tari-project#4050) chore(deps): bump async from 3.2.1 to 3.2.3 in /integration_tests (tari-project#4035) chore(deps): bump async from 2.6.3 to 2.6.4 in /applications/tari_web_extension (tari-project#4059) fix: weird behaviour of dates in base node banned peers (tari-project#4037) test(covenant): improve test coverage (tari-project#4052) chore: obscure grpc error response (tari-project#3995) test: cucumber saf test (tari-project#3135) fix(wallet): do not prompt for password if given in config (tari-project#4040) ...
* development: chore: update launchpad backend (tari-project#4017) feat: allow network to be set by TARI_NETWORK env var (tari-project#4073) fix: support safe non-interactive mode (tari-project#4072) feat(collectibles): add list assets command (tari-project#3908)
stringhandler
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Schnorr signatures are not secure unless public nonce and public key are committed to
How Has This Been Tested?
Existing tests (internal to identity signature)