Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dht): convenience function for DHT to discover then connect #3840

Merged
merged 3 commits into from
Feb 23, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Feb 15, 2022

Description

  • adds DhtRequester::dial_or_discover_peer(public_key: CommsPublicKey) method
  • Update Validator node client code to use dial_or_discover_peer
  • add new unit tests

Motivation and Context

Components may need to discover unknown peers before contacting them via RPC. This function provides a way to do that.

How Has This Been Tested?

New unit tests

@delta1 delta1 changed the title feat(dht): convinience function for DHT discover then connect feat(dht): convenience function for DHT to discover then connect Feb 15, 2022
@sdbondi sdbondi force-pushed the dht-discovery-dial branch 4 times, most recently from 7200573 to 440abc2 Compare February 15, 2022 11:18
@delta1
Copy link
Contributor

delta1 commented Feb 22, 2022

Please resolve conflicts when you can @sdbondi

Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@aviator-app aviator-app bot merged commit da59c85 into tari-project:development Feb 23, 2022
@sdbondi sdbondi deleted the dht-discovery-dial branch February 24, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants