Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update RFC links and README (#3675) #3839

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

zhangcheng
Copy link
Contributor

Description

Update in light of #3675.
For reason unknown to me, the link to RFC_template.md also has to appear in
SUMMARY.md. Otherwise, it will be a 404 as reported (somehow the HTML file is
not generated).

Motivation and Context

See above.

How Has This Been Tested?

Manual check.

Description
---
Update in light of tari-project#3675.
For reason unknown to me, the link to RFC_template.md also has to appear in
SUMMARY.md. Otherwise, it will be a 404 as reported (somehow the HTML file is
not generated).

Motivation and Context
---
See above.

How Has This Been Tested?
---
Manual check.
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@zhangcheng
Copy link
Contributor Author

Just some doc text changed, it shouldn't cause CI test failure, right?

@delta1
Copy link
Contributor

delta1 commented Feb 16, 2022

Just some doc text changed, it shouldn't cause CI test failure, right?

No I think it's unrelated

@aviator-app aviator-app bot removed the mq-failed label Feb 16, 2022
@aviator-app aviator-app bot merged commit 22416a1 into tari-project:development Feb 16, 2022
@zhangcheng zhangcheng deleted the rfc-link-update branch February 16, 2022 11:42
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 17, 2022
* development: (28 commits)
  fix(wallet): fix aggressive disconnects in wallet connectivity (tari-project#3807)
  chore: honor decimals in ERC20 (tari-project#3809)
  chore: add icons to applications (tari-project#3812)
  fix: daily test (tari-project#3815)
  ci: improvements to macos pkg (tari-project#3824)
  ci: cargo test speedups (tari-project#3843)
  feat: add persistence of transaction cancellation reason to wallet db (tari-project#3842)
  fix: update RFC links and README (tari-project#3675) (tari-project#3839)
  chore: change NodeIdentity debug (tari-project#3817)
  fix(dan): include state_root in node hash (tari-project#3836)
  feat(cli): resize terminal height (tari-project#3838)
  feat(validator-node): initial state sync implementation (partial) (tari-project#3826)
  feat: update console wallet tui (tari-project#3837)
  feat: resize base node terminal on startup (tari-project#3827)
  feat(wallet): add grpc method for setting base node (tari-project#3828)
  chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension_example (tari-project#3832)
  chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/tari_collectibles/web-app (tari-project#3833)
  chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension (tari-project#3834)
  chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/launchpad/gui-vue (tari-project#3831)
  chore(deps): bump follow-redirects from 1.14.4 to 1.14.8 in /integration_tests (tari-project#3829)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants