Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update console wallet tui #3837

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Feb 14, 2022

Description

Updated console wallet TUI to better accommodate the expanding number of tabs:

  • Moved base node status to the bottom of the screen, expanding tab selection to
    the entire width.
  • Regained 1 line of real estate screen space at the bottom of the screen
    (with menu).
  • Refined some help text to fit on the screen.
  • Added a separate contacts tab to enable better handling of contacts not
    needing to access it via the transaction send tab.
  • Improved column spacing on the contacts tab/pane.
  • Improved the receive tab layout (moved connection details above the QR code).
  • Removed contacts editing ability from the sent tab; only selection remains.

Some screenshots:

image

image

image

Motivation and Context

See above

How Has This Been Tested?

System level tests

@delta1
Copy link
Contributor

delta1 commented Feb 14, 2022

Nice! Will take a look. I personally think that Events and Logs should be hidden and then enabled with some kind of “dev” or “debug” mode/key (but that’s a separate change)

@hansieodendaal
Copy link
Contributor Author

Nice! Will take a look. I personally think that Events and Logs should be hidden and then enabled with some kind of “dev” or “debug” mode/key (but that’s a separate change)

Thanks and agreed, that should be a separate PR.

… of tabs:

- Moved base node status to the bottom of the screen, expanding tab selection to
  the entire width.
- Regained 1 line of real estate screen space at the bottom of the screen
  (with menu).
- Refined some help text to fit on the screen.
- Added a separate contacts tab to enable better handling of contacts not
  needing to access it via the transaction send tab.
- Improved column spacing on the contacts tab/pane.
- Improved the recieve tab layout (moved connection details above the QR code).
- Removed contacts editing ability from the sent tab; only selection remains.
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good

@aviator-app aviator-app bot merged commit 3403db6 into tari-project:development Feb 15, 2022
@hansieodendaal hansieodendaal deleted the ho_upadate_console_wallet_ui branch February 15, 2022 08:05
sdbondi added a commit to sdbondi/tari that referenced this pull request Feb 17, 2022
* development: (28 commits)
  fix(wallet): fix aggressive disconnects in wallet connectivity (tari-project#3807)
  chore: honor decimals in ERC20 (tari-project#3809)
  chore: add icons to applications (tari-project#3812)
  fix: daily test (tari-project#3815)
  ci: improvements to macos pkg (tari-project#3824)
  ci: cargo test speedups (tari-project#3843)
  feat: add persistence of transaction cancellation reason to wallet db (tari-project#3842)
  fix: update RFC links and README (tari-project#3675) (tari-project#3839)
  chore: change NodeIdentity debug (tari-project#3817)
  fix(dan): include state_root in node hash (tari-project#3836)
  feat(cli): resize terminal height (tari-project#3838)
  feat(validator-node): initial state sync implementation (partial) (tari-project#3826)
  feat: update console wallet tui (tari-project#3837)
  feat: resize base node terminal on startup (tari-project#3827)
  feat(wallet): add grpc method for setting base node (tari-project#3828)
  chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension_example (tari-project#3832)
  chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/tari_collectibles/web-app (tari-project#3833)
  chore(deps): bump follow-redirects from 1.14.5 to 1.14.8 in /applications/tari_web_extension (tari-project#3834)
  chore(deps): bump follow-redirects from 1.14.7 to 1.14.8 in /applications/launchpad/gui-vue (tari-project#3831)
  chore(deps): bump follow-redirects from 1.14.4 to 1.14.8 in /integration_tests (tari-project#3829)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants