feat!: add scanned transaction handling for one-sided payments with callbacks #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_add_scanned_tx_handling
branch
from
ac26982
to
a6ecf90
Compare
philipr-za
reviewed
Feb 4, 2022
There was a problem hiding this comment.
So I feel like something is missing here. The scanned output faux transactions cannot be validated like normal transactions because we do not know their kernels. Their status needs to be driven by the status of the outputs, which for imported transaction was done using the check_imported_transactions task but I can't see anything similar for ScannedUnconfirmed outputs.
base_layer/wallet/src/transaction_service/protocols/transaction_validation_protocol.rs
Outdated
Show resolved
Hide resolved
hansieodendaal
force-pushed
the
ho_add_scanned_tx_handling
branch
from
a6ecf90
to
3d1029e
Compare
hansieodendaal
changed the title
- Added separate statuses for faux transactions to enable unique events and validation for scanned one-sided transactions. - Added validation for one-sided payments updating the associated faux transaction mined height and confirmations. - Added callbacks for faux transactions (unconfirmed and confirmed). - Updated the wallet FFI with the callbacks.
hansieodendaal
force-pushed
the
ho_add_scanned_tx_handling
branch
from
3d1029e
to
fb1a416
Compare
hansieodendaal
changed the title
philipr-za
approved these changes
Feb 9, 2022
Comment on lines
+36
to
+50
| impl TransactionStatus { | ||
| pub fn is_faux(&self) -> bool { | ||
| match self { | ||
| TransactionStatus::Completed => false, | ||
| TransactionStatus::Broadcast => false, | ||
| TransactionStatus::MinedUnconfirmed => false, | ||
| TransactionStatus::Imported => true, | ||
| TransactionStatus::Pending => false, | ||
| TransactionStatus::Coinbase => false, | ||
| TransactionStatus::MinedConfirmed => false, | ||
| TransactionStatus::Rejected => false, | ||
| TransactionStatus::FauxUnconfirmed => true, | ||
| TransactionStatus::FauxConfirmed => true, | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| impl TransactionStatus { | |
| pub fn is_faux(&self) -> bool { | |
| match self { | |
| TransactionStatus::Completed => false, | |
| TransactionStatus::Broadcast => false, | |
| TransactionStatus::MinedUnconfirmed => false, | |
| TransactionStatus::Imported => true, | |
| TransactionStatus::Pending => false, | |
| TransactionStatus::Coinbase => false, | |
| TransactionStatus::MinedConfirmed => false, | |
| TransactionStatus::Rejected => false, | |
| TransactionStatus::FauxUnconfirmed => true, | |
| TransactionStatus::FauxConfirmed => true, | |
| } | |
| } | |
| impl TransactionStatus { | |
| pub fn is_faux(&self) -> bool { | |
| match self { | |
| TransactionStatus::Imported | | |
| TransactionStatus::FauxUnconfirmed | | |
| TransactionStatus::FauxConfirmed => true, | |
| _ => false, | |
| } | |
| } |
There was a problem hiding this comment.
Thanks, I will fix that as a side issue when I submit a new PR based on this merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Currently when a one-sided output is found by scanning the blockchain a Faux transaction is created for it with the Imported status, the same as for a manually imported output. Outputs found by scanning (for one-sided payments) should be handled differently to a manual import and their mined height and number confirmations should be validated.
How Has This Been Tested?