Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add connect per site into the web extension #3626

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Nov 29, 2021

Description

Add connect feature to tari web extension. It allows user to grand permission to the extension. Currently there is only true/false permission, but the code is ready to handle specific permissions.

Future work

  • We need carefully audit the code to see if there is no backdoor (e.g. any site getting access without triggering the user confirmation). I currently don't see any, but the ports and window.postMessage that are used to communicate between the 3 parties involved (background.js, content.js, web).
  • Disconnect feature, revoking access to the extension
  • UI
  • There is a popup flash when you didn't do the onboarding yet and you want to connect it to the website.

How Has This Been Tested?

Manually.

Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM untested

@stringhandler stringhandler merged commit 75aa0a3 into tari-project:validator-node Nov 29, 2021
sdbondi added a commit to sdbondi/tari that referenced this pull request Dec 12, 2021
* development: (77 commits)
  chore: merge development
  refactor: split transaction file (tari-project#3653)
  refactor: change transaction mod name
  chore: fix imports fmt (tari-project#3650)
  feat: add 721 template stub (tari-project#3643)
  feat: add transfer method to tip002 (tari-project#3632)
  feat: add connect per site into the web extension (tari-project#3626)
  refactor: fix db structure (tari-project#3616)
  feat: add asset key manager to collectibles (tari-project#3609)
  ci: update validator-node CI for faster feedback (tari-project#3606)
  feat: add state database (tari-project#3591)
  feat: add wallet stub to collectibles app (tari-project#3589)
  feat: add onboarding flow for web extension (tari-project#3582)
  feat: compile key manager to wasm and add javascript interface (tari-project#3565)
  feat: add storage to validator node (tari-project#3551)
  fix: wallet was not able to run (tari-project#3561)
  feat: add react popup with some basic functionality (tari-project#3550)
  feat: create tari web extension application stub (tari-project#3535)
  chore: merge dev
  refactor: move conversion
  ...
@Cifko Cifko deleted the connect-feature branch January 9, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants