fix: improve handling of old base nodes and reorgs in wallet recovery #3608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two quick improvements on the wallet recovery: - Gracefully handle the case where the base node is older and doesn’t support the `get_height_at_time` RPC call yet. - If a reorg is detected during recovery the process used to be restarted from the genesis block. Now it will restart from the wallet birthday
stringhandler
approved these changes
Nov 23, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 25, 2021
* development: chore: public_address for TCP node has higher priority from env/config (tari-project#3600) fix: improve handling of old base nodes and reorgs in wallet recovery (tari-project#3608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two quick improvements on the wallet recovery:
get_height_at_timeRPC call yet.How Has This Been Tested?
Manually