Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tcp tls backend for peer seed DNS resolution #3544

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Nov 7, 2021

Description

  • Use TCP TLS backend for DNS
  • Add TLS root certs from webpki_roots
  • Don't crash node if DNS fails to resolve
  • Update config

Motivation and Context

UDP stream does not work with seeds.weatherwax.tari.com

Dependencies:
tari_p2p:

  • upgrade trust-dns-client to version "0.21.0-alpha.4"
  • add rustls = "0.19.1" used for TLS support
  • add webpki = "0.21" for root cert container struct used by trust-dns-client

How Has This Been Tested?

Existing tests
Manually on base node

@sdbondi sdbondi force-pushed the p2p-fix-dns-resolution-use-tcp branch from 8f3e7b2 to 001e713 Compare November 8, 2021 05:31
@sdbondi sdbondi changed the title fix: use tcp backend for peer seed DNS resolution fix: use tcp tls backend for peer seed DNS resolution Nov 8, 2021
@sdbondi sdbondi force-pushed the p2p-fix-dns-resolution-use-tcp branch 8 times, most recently from c9ba29e to fdd9520 Compare November 8, 2021 06:44
@sdbondi sdbondi force-pushed the p2p-fix-dns-resolution-use-tcp branch from fdd9520 to be804fc Compare November 8, 2021 06:45
@aviator-app aviator-app bot merged commit 5b38909 into tari-project:development Nov 8, 2021
@sdbondi sdbondi deleted the p2p-fix-dns-resolution-use-tcp branch November 9, 2021 04:51
@sdbondi sdbondi restored the p2p-fix-dns-resolution-use-tcp branch February 3, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants