fix: remove unbounded vec allocations from base node grpc/p2p messaging #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-fetch-headers
branch
2 times, most recently
from
badb254
to
03d2b45
Compare
- replaces unbounded height lists with bound height ranges in internal base node service interfaces and p2p messaging - removes unused and deprecated base node p2p messaging requests/responses - load chain headers when requesting headers, this simplifies and reduces the database load when calling grpc get_blocks - use iterator with almost no footprint for paging in grpc calls - implement `DoubleSidedIterator` for `NonOverlappingIntegerPairIter` - add overflow protection to `NonOverlappingIntegerPairIter` and additional tests
sdbondi
force-pushed
the
core-fetch-headers
branch
from
03d2b45
to
81b633d
Compare
base_layer/core/src/base_node/comms_interface/local_interface.rs
Outdated
Show resolved
Hide resolved
base_layer/core/src/base_node/comms_interface/local_interface.rs
Outdated
Show resolved
Hide resolved
stringhandler
previously approved these changes
Oct 19, 2021
* development: feat: tx weight takes tariscript and output features into account [igor] (tari-project#3411)
stringhandler
approved these changes
Oct 19, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Oct 25, 2021
* development: (31 commits) feat!: revalidate all outputs (tari-project#3471) fix: check SAF message inflight and check stored_at is in past (tari-project#3444) feat!: apps should not depend on other app configs (tari-project#3469) fix: fix recovery test reporting message (tari-project#3479) chore: improve cucumber tests to wait for broadcast (tari-project#3461) test: use TCP node for daily sync test (tari-project#3464) fix: remove unbounded vec allocations from base node grpc/p2p messaging (tari-project#3467) fix: upgrade rustyline dependencies (tari-project#3476) fix(dht): discard encrypted message with no destination (tari-project#3472) fix: remove consensus breaking change in transaction input (tari-project#3474) feat: tx weight takes tariscript and output features into account [igor] (tari-project#3411) fix: validate dht header before dedup cache (tari-project#3468) fix: sha256sum isn't available on all *nix platforms (tari-project#3466) fix: typo in console wallet (tari-project#3465) fix: ensure that accumulated orphan chain data is committed before header validation (tari-project#3462) fix: remove is_synced check for transaction validation (tari-project#3459) feat: improve logging for tari_mining_node (tari-project#3449) fix: remove unnecessary wallet dependency (tari-project#3438) test: simplify cucumber tests (tari-project#3457) ci: create script to update DNS records from hashes.txt (tari-project#3458) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
interfaces and p2p messaging
reduces the database load when calling grpc get_blocks
DoubleSidedIteratorforNonOverlappingIntegerPairIterNonOverlappingIntegerPairIterandadditional tests
This PR does not contain any breaking changes, as no nodes using the base node p2p messaging interface except for block propagation (which is unchanged). GRPC protobuf contract is preserved.
New dependency
either = "1.6.1"added totari_base_nodecrate and used for itsEitheriterator implMotivation and Context
Closes #3310
How Has This Been Tested?
Existing GRPC tests
Manually tested block explorer api connected to local base node
Additional unit tests