feat: ping-peer command #3295
Merged
feat: ping-peer command #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
base-node-ping-peer
branch
from
4c02676
to
e475d20
Compare
philipr-za
reviewed
Sep 6, 2021
| pub fn ping_peer(&self, dest_node_id: NodeId) { | ||
| let mut liveness = self.liveness.clone(); | ||
|
|
||
| self.executor.spawn(time::timeout(Duration::from_secs(30), async move { |
There was a problem hiding this comment.
Maybe just a message if it hits the timeout?
There was a problem hiding this comment.
Yeah first prize would be to improve liveness service to allow for a ping/pong result to be returned to a caller - for now, I think a message here will work - will add now
stringhandler
approved these changes
Sep 6, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
Description --- `ping-peer [emoji id | pk | nodeid ]` Motivation and Context --- Allows latency tests pinging of peers using the liveness service How Has This Been Tested? --- Manually by running the command on a base node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ping-peer [emoji id | pk | nodeid ]Motivation and Context
Allows latency tests pinging of peers using the liveness service
How Has This Been Tested?
Manually by running the command on a base node