fix: prevent immediate run of wallet recovery on cron script #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
force-pushed
the
tooling-fix-cron
branch
from
d579338
to
0899606
Compare
sdbondi
force-pushed
the
tooling-fix-cron
branch
2 times, most recently
from
08cf4fe
to
1ef8234
Compare
stringhandler
previously approved these changes
Aug 30, 2021
|
PR queued successfully. Your position in queue is: 9 |
sdbondi
force-pushed
the
tooling-fix-cron
branch
from
70cebfe
to
e0b2001
Compare
When running cron, the two walet receovery tests would run immediately and not be awaited (Promises are eager in js) - Fix " ReferenceError: Cannot access recoveredAmount before initialization"
sdbondi
force-pushed
the
tooling-fix-cron
branch
from
e0b2001
to
cd28682
Compare
stringhandler
approved these changes
Sep 6, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
…oject#3260) Description --- When running cron, the two wallet recovery tests would run immediately and not be awaited (Promises are eager in js) Motivation and Context --- Minor fix How Has This Been Tested? --- Script run and tests did not immediately start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running cron, the two wallet recovery tests would run immediately
and not be awaited (Promises are eager in js)
Motivation and Context
Minor fix
How Has This Been Tested?
Script run and tests did not immediately start