Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow issue on windows when spawning DHT inbound message pipeline #1416

Closed
sdbondi opened this issue Mar 5, 2020 · 5 comments
Closed
Labels
A-comms Area - Comms C-bug Category - fixes a bug, typically associated with an issue. X-windows Platform - Windows

Comments

@sdbondi
Copy link
Member

sdbondi commented Mar 5, 2020

Thanks to @hansieodendaal for reporting: The tari_base_node creates a stack overflow error when run in Windows. This has been traced to the implementation of multiple Tokio layers in pub fn inbound_middleware_layer. Excluding the 2x store_forward Tokio layers works for now. It seems this problem is related to the amount of layers added as well.

The tokio::runtime::Builder::new().thread_stack_size has been increased from 2MB to 200MB but this did not solve the problem.

More context #1414

@sdbondi sdbondi added the A-comms Area - Comms label Mar 5, 2020
@sdbondi sdbondi changed the title Stack overflow issue with windows on DHT inbound message pipeline Stack overflow issue on windows when spawning DHT inbound message pipeline Mar 5, 2020
@CjS77 CjS77 added C-bug Category - fixes a bug, typically associated with an issue. X-windows Platform - Windows labels Apr 16, 2020
@delta1
Copy link
Contributor

delta1 commented Jul 13, 2021

can this be closed @hansieodendaal @Cifko?

@Cifko
Copy link
Contributor

Cifko commented Jul 14, 2021

can this be closed @hansieodendaal @Cifko?

IMHO yes. I will test it on my NB as well, if everything goes well I will close it.

@delta1
Copy link
Contributor

delta1 commented Jul 14, 2021

Thanks @Cifko

@Cifko
Copy link
Contributor

Cifko commented Jul 14, 2021

Works fine on NB as well.

@Cifko Cifko closed this as completed Jul 14, 2021
@hansieodendaal
Copy link
Contributor

Confirmed from my side as well, whoop whoop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-comms Area - Comms C-bug Category - fixes a bug, typically associated with an issue. X-windows Platform - Windows
Projects
None yet
Development

No branches or pull requests

5 participants