Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(wallet-ffi): don't block on start (#5437)
Description --- Currently the ffi call to create and start the wallet will block until connections have been made. Instead return the Wallet asap, and throw the previously blocking call into an async non blocking call and let it complete on its own time. Motivation and Context --- The wallet freezes up for a duration while connecting to tor and the base node if the user has low connectivity. This prevents all other local actions from functioning. Instead we can return an initialized wallet that doesn't have connectivity allowing for local manipulation and gain connectivity in the background. How Has This Been Tested? --- CI only What process can a PR reviewer use to test or verify this change? --- Watch for green checks <!-- Checklist --> <!-- 1. Is the title of your PR in the form that would make nice release notes? The title, excluding the conventional commit tag, will be included exactly as is in the CHANGELOG, so please think about it carefully. --> Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
- Loading branch information