Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(peersync)!: push local peer record to connected peer on change #1202

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Nov 13, 2024

Description

feat(peersync)!: push local peer record to connected peer on change
Add libp2p logs to log4rs

Motivation and Context

Connected peers should have an up-to-date and shareable address record for peers they are connected to. This PR adds this to the peer sync protocol.

How Has This Been Tested?

Manually - looked at logs to observe it working

What process can a PR reviewer use to test or verify this change?

Given node A connected to node B prior, a node C can request node B from Node A and always get a response.

Breaking Changes

  • None
  • Requires data directory to be deleted
  • Other - Please specify

BREAKING CHANGE: peer sync protocol is not compatible with previous versions

Copy link

github-actions bot commented Nov 13, 2024

Test Results (CI)

561 tests  ±0   561 ✅ ±0   1h 27m 7s ⏱️ + 11m 20s
 54 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bcf0b39. ± Comparison against base commit 2663740.

♻️ This comment has been updated with latest results.

@sdbondi sdbondi merged commit 01114b0 into tari-project:development Nov 22, 2024
11 of 12 checks passed
@sdbondi sdbondi deleted the peersync-send-local-rec branch November 22, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants