fix(sync)!: validate checkpoint merkle root #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
consensus-and-sync-validate-mr
branch
from
9b13d96
to
38bfa5a
Compare
sdbondi
force-pushed
the
consensus-and-sync-validate-mr
branch
from
38bfa5a
to
b65a529
Compare
stringhandler
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(sync): validate checkpoint merkle root
Rename NumPreshard variants (#1092 (comment))
Motivation and Context
Validates the checkpoint blocks merkle root against the synced state so that the validator can be sure they have the correct state. Note that block and QC signatures are not currently validated pending a refactor in the validations.
How Has This Been Tested?
Manually, submitting transactions, mining to next epoch, submitting more transactions, deleting data of one VN and resyncing.
What process can a PR reviewer use to test or verify this change?
As above
Breaking Changes
BREAKING CHANGE: the merkle root construction differs slightly from current development branch