-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new instruction type AssertBucketContains #1106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AssertBucketContains
and associated utils and errorstari_dan_wallet_web_ui
npm dependencies with bindings and clients use the npm registry instead of local dependencies, to avoid chicken-and-egg situations.Motivation and Context
We want a new type of transaction instruction to execute asserts. Asserts can be useful in a variety of ways, making transactions more secure and easier to review by the user. For example, it could allow to implement a maximum slippage in a decentralized exchange.
The main use case is to ensure that the return bucket of a component call invocation contains the expected resource and amount of tokens, hence the new instruction is called
AssertBucketContains
. The fields of the new instruction type are:key
: workspace reference of the bucket that we want to assertresource_address
: the resource address that the bucket must containmin_amount
: the minimum amount of tokens that the bucket must containHow Has This Been Tested?
New engine unit tests that cover all scenarios
What process can a PR reviewer use to test or verify this change?
Send a transaction with the new instruction type
Breaking Changes