Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes qgridnext import error in tests #2834

Merged

Conversation

andrewfullard
Copy link
Contributor

📝 Description

Type: 🪲 bugfix

The previous qgridnext import check #2819 caused tests to fail. This version falls back to regular qgrid, which will still raise an exception logging error but prevents test failures.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Sep 30, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (d75e778).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Complete output(might be large):

All checks passed!

@tardis-bot
Copy link
Contributor

tardis-bot commented Sep 30, 2024

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.51%. Comparing base (4c6780c) to head (d75e778).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
tardis/visualization/widgets/util.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2834      +/-   ##
==========================================
- Coverage   70.87%   70.51%   -0.37%     
==========================================
  Files         209      209              
  Lines       15589    15589              
==========================================
- Hits        11049    10992      -57     
- Misses       4540     4597      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard andrewfullard merged commit 3b6084f into tardis-sn:master Sep 30, 2024
12 of 14 checks passed
CePowers pushed a commit to CePowers/tardis that referenced this pull request Oct 1, 2024
Fallback to qgrid (currently in lock files)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants