Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure radiation field #2474

Merged
merged 108 commits into from
Dec 11, 2023
Merged

Restructure radiation field #2474

merged 108 commits into from
Dec 11, 2023

Conversation

wkerzendorf
Copy link
Member

No description provided.

@wkerzendorf
restructure of geometry
314cf30
@wkerzendorf
add radial1d boundary logic
d353133
@wkerzendorf
black format
2475551
@wkerzendorf
several fixes
e6d1697
@wkerzendorf
fix epsilon
3c53cda
@wkerzendorf
add testing of boundaries
6dce2b4
@wkerzendorf
change the r_inner_active
1fdcea8
@wkerzendorf
first integration with from_config working
56e9da5
@wkerzendorf
hunting down density indexing bug
f6743d7
@wkerzendorf
all model tests (without csvy) pass
b55b21d
@wkerzendorf
more fixes
ed978d9
@wkerzendorf
fix of model to simulation_state
cae9c19
@wkerzendorf
fix inner boundary packet error
d829e73
@wkerzendorf
fix some leftovers
9592a97
@wkerzendorf
final fix for csvy
4da6869
@wkerzendorf
blackify
f381d2e
@wkerzendorf
restructure to readers and remove some leftover code
e59741d
@wkerzendorf
further cleanup
a42dd55
@wkerzendorf
first start of the restructure
3288c6c
@wkerzendorf
add comment about removing quantitiness
518a8f9
@wkerzendorf
add velocity check
c78b6de
@wkerzendorf
add new abundance functions
006ca9d
@wkerzendorf
remove default units
9c680a8
@wkerzendorf
add new matter module
268bd23
@wkerzendorf
several restructures. move decay from io to tardis/model/matter
6b03e93
@wkerzendorf
mid restructure
3114413
@wkerzendorf
slow progress on abundance refactor
217dcf2
@wkerzendorf
include effective_element_masses
78055b4
@wkerzendorf
Merge remote-tracking branch 'upstream/master' into restructure/abund…
73f5175 
…ance
@wkerzendorf
further updates
b96d717
@wkerzendorf wkerzendorf force-pushed the restructure/radiation_field branch 2 times, most recently from 6a45fe5 to b7f0c53 Compare December 4, 2023 05:40
@wkerzendorf wkerzendorf force-pushed the restructure/radiation_field branch from b7f0c53 to 361e0b7 Compare December 4, 2023 05:43
@tardis-bot
Copy link
Contributor

tardis-bot commented Dec 4, 2023 •
edited
Loading

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (caffb25) 68.36% compared to head (1cc8004) 68.47%.
Report is 1 commits behind head on master.

Files Patch % Lines
tardis/io/model_reader.py 0.00% 7 Missing ⚠️
tardis/model/parse_input.py 85.10% 7 Missing ⚠️
tardis/model/geometry/radial1d.py 83.33% 2 Missing ⚠️
...dis/montecarlo/montecarlo_numba/tests/test_base.py 94.73% 2 Missing ⚠️
tardis/model/base.py 95.65% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2474      +/-   ##
==========================================
+ Coverage   68.36%   68.47%   +0.11%     
==========================================
  Files         158      159       +1     
  Lines       13861    13854       -7     
==========================================
+ Hits         9476     9487      +11     
+ Misses       4385     4367      -18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrewfullard
andrewfullard reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very minor comments

tardis/model/base.py Outdated Show resolved Hide resolved
tardis/model/radiation_field_state.py Outdated Show resolved Hide resolved
@jvshields
Copy link
Contributor

The code looks good to me. Waiting to see if the build-docs passes and then approving if so.

@jvshields jvshields self-requested a review December 11, 2023 15:45
@wkerzendorf wkerzendorf merged commit df439d8 into tardis-sn:master Dec 11, 2023
11 of 12 checks passed
@wkerzendorf wkerzendorf mentioned this pull request Jun 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Knights-Templars Knights-Templars Knights-Templars left review comments

@andrewfullard andrewfullard andrewfullard left review comments

@jvshields jvshields jvshields approved these changes

Assignees
No one assigned
Labels
build-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wkerzendorf @tardis-bot @jvshields @andrewfullard @Knights-Templars