Remove lock file creation from pre release workflow #2432

atharva-2001 · 2023-10-06T12:56:42Z

📝 Description

Type: | 🎢 infrastructure

This updates mamba version to avoid conda-lock problems. The conda-incubator/setup-miniconda@v2 doesn't install mamba to latest versions.

📌 Resources

Examples, notebooks, and links to useful references.

Edited workflow for demonstration-
https://github.com/atharva-2001/tardis/actions/runs/6431988476

🚦 Testing

How did you test these changes?

Testing pipeline
Other method (describe)
My changes can't be tested (explain why)

☑️ Checklist

I requested two reviewers for this pull request
I updated the documentation according to my changes
I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

codecov · 2023-10-06T13:17:19Z

Codecov Report

Merging #2432 (4edc270) into master (70fcf0b) will decrease coverage by 0.04%.
Report is 3 commits behind head on master.
The diff coverage is 11.11%.

❗ Current head 4edc270 differs from pull request most recent head a048ff6. Consider uploading reports for the commit a048ff6 to get more accurate results

@@            Coverage Diff             @@
##           master    #2432      +/-   ##
==========================================
- Coverage   66.94%   66.91%   -0.04%     
==========================================
  Files         153      153              
  Lines       13628    13636       +8     
==========================================
+ Hits         9123     9124       +1     
- Misses       4505     4512       +7

Files	Coverage Δ
tardis/plasma/properties/atomic.py	`85.60% <33.33%> (-0.62%)`	⬇️
tardis/energy_input/gamma_ray_transport.py	`0.00% <0.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andrewfullard

Looks great! Now we can have releases again. Can you check the post-release to make sure it doesn't do anything that relies on the lock file? Can you check the documentation about installation so that it works with the correct lock file?

atharva-2001 · 2023-10-06T13:39:21Z

Looks great! Now we can have releases again. Can you check the post-release to make sure it doesn't do anything that relies on the lock file? Can you check the documentation about installation so that it works with the correct lock file?

On it! Would let you know once I've checked!

atharva-2001 · 2023-10-09T10:34:59Z

I saw nothing related to the lock file in the post-release workflow. These lines/section from the documentation should be removed however-
conda install tardis-sn --channel conda-forge --no-deps

and

https://tardis-sn.github.io/tardis/installation.html#install-from-package

Rest everything works for me.
I was unable to do the conda package installation(conda install tardis-sn...) after the new env setup. I am removing those sections in this PR- if this is not the right thing to do, please let me know and I would remove the commit.

…and comment out install from package

tardis-bot · 2023-10-09T11:16:43Z

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

wkerzendorf · 2023-10-10T19:11:12Z

can we finish this?

andrewfullard · 2023-10-17T13:20:29Z

Looks good to me. Please change the PR title!

atharva-2001 · 2023-10-17T15:19:01Z

Please change the PR title!

Done!

* Allow Simulation Tests to Run Independently (tardis-sn#2407) * Modify test_packet_source.py so that sim and tardis/tests can run * remove BasePacketSource * format * Add docstrings * Pre-release 2023.09.17 (tardis-sn#2411) Automated changes for pre-release 2023.09.17 * upgrading env in 2022 (tardis-sn#2410) * fix several bugs related to upgrade * fix the get function in pandas * fixed several incompatibilities for new libraries * fixed up the changes in pandas testing and other reindexing issues * fix other bugs with new environment * blackify tardis * updated the conda-lock file * add lock files * update cache number * fix simulation tests * remove units for testing * blackify * Update tardis/visualization/tools/tests/test_sdec_plot.py good catch Co-authored-by: Atharva Arya <[email protected]> * add assert * reset caches --------- Co-authored-by: Atharva Arya <[email protected]> * In gamma ray code : Changed times to np.geomspace (tardis-sn#2415) * Changed times to np.geomspace * Added myself to mailmap * rename RadialModel1D to SimulationState (tardis-sn#2417) * rename RadialModel1D to SimulationState * black files * rename simulation_state2 (tardis-sn#2421) * fixup of many files to make them pass the tests * change model for typo * Ignore tests in docstr coverage (tardis-sn#2424) ignore tests in docstr coverage * Disabled formal integral for continuum interaction (tardis-sn#2426) Disabled formal integral Co-authored-by: Alexander Holas <alexander.holas@h-its> * add linelist exposure to atom data and reader, built on current (tardis-sn#2428) * add linelist exposure to atom data and reader, built on current * add josh to mailmap * Modified how setup input energy takes isotope name. Earlier it was ga… (tardis-sn#2425) Modified how setup input energy takes isotope name. Earlier it was gamma_ray_lines.Isotope * Added a function to calculate shell masses (tardis-sn#2434) * Added a function to calculate shell masses * Added a function to calculate shell masses * changed shell masses with the new function * Fix duplicate entries in continuum line list (tardis-sn#2443) * Workaround list access * Formatting * Added error if duplicate * Remove duplicates * Fix typo, add comment * Remove bandaid fix * Cleanup * More cleanup * Fix numba parallel issues (tardis-sn#2447) * Enabled parallel * Fix the mistake * Update docs * Change glob patterns in `setup.cfg` (tardis-sn#2441) * Fix package_data in setup.cfg, mainly io and viz * more folders * Test pip installation * Remove test step * Fix more folders * restructure of geometry (tardis-sn#2422) * restructure of geometry * add radial1d boundary logic * black format * several fixes * fix epsilon * add testing of boundaries * change the r_inner_active * first integration with `from_config` working * hunting down density indexing bug * all model tests (without csvy) pass * more fixes * fix of model to simulation_state * fix inner boundary packet error * fix some leftovers * final fix for csvy * blackify * restructure to readers and remove some leftover code * further cleanup * first start of the restructure * add comment about removing quantitiness * add velocity check * add new abundance functions * remove default units * Add FAQ section to documentation (tardis-sn#2450) * Add faq * Added Overview * Fix typo * Remove lock file creation from pre release workflow (tardis-sn#2432) * Install latest version of mamba * Unpin conda lock installatiion * Split lockfilee creation to separate workflow * change docs installation- put a warning for conda forge installation and comment out install from package * fix * delete create lockfiles * download llock file * Pre-release 2023.10.20 (tardis-sn#2452) Automated changes for pre-release 2023.10.20 * Add verbose assert to NLTE rate equation (tardis-sn#2457) * add verbose assert * formatting * Fix bug in relativistic packet source (tardis-sn#2453) * Fix bug in relativistic packet source * Add initial test for BlackBodySimpleSourceRelativistic * Remove incorrect docstring * Update tardis/montecarlo/tests/test_packet_source.py Co-authored-by: Wolfgang Kerzendorf <[email protected]> * Update tardis/montecarlo/tests/test_packet_source.py Co-authored-by: Wolfgang Kerzendorf <[email protected]> * Rename all occurences of blackbodysimplesourcerelativistic * Do not hardcore blackbody_simplesource_relativistic.beta --------- Co-authored-by: Wolfgang Kerzendorf <[email protected]> * Enable nlte ionization as plasma component (tardis-sn#2458) * Rename nlte ion and electron * Enable NLTE * Fix typo * Add docs * Fix transitionprob dtype * dtype conversion * dtype for sparse matrix * Typing in numba * Fix test variable name * Add missing electron density case * Fix typo * Update docstr-cov.yml to fix failing action (tardis-sn#2462) * Update docstr-cov.yml to fix failing action * Explicitly install setuptools * NLTE Ionization solver polish (tardis-sn#2461) * assertion for first guess * Add checks to decay * Fix greater equal * Fix deprecated series index * Pre-release 2023.11.05 (tardis-sn#2466) Automated changes for pre-release 2023.11.05 * Tests Plasma Using Syrupy (tardis-sn#2413) * Add syrupy classes to conftest * Add syrupy to env file * Another folder for syrupy data * Save as npy instead of txt * Use syrupy fixtures * Different assertion functions for pandas dataframes and series * Zeta data fix * Blackify * Blackify conftest * test_hdf_plasmas using syrupy * Install syrupy with conda * Remove additional line adding syrupy as a plugin * Set update snapshots config option when generate reference is selected * Remove old refdata code from test plasmas complete * Create plasma conftest file * Text based snapshot fixture with custom location * Snapshot path * tardis regressions my fork * Refactor test_hdf_plasmas.py * Format using black * test nlte excitation using syrupy * nlte solver * plasma continuum * test tardis model density config * Lock files * Increase cache no * format using black * cleanup- sort dependencies, delete comments * Documentation to run these tests * remove commented out fixtures which are not used anywhere * docs code render fix * tests final cleanup * renaming files, yet to deal with ambr snapshot extension and curly brackets * renaming snapshots * Add comments * Add astropy import guard (tardis-sn#2470) * Add astropy import guard * mailmap * Reading in decay radiation data in atom data (tardis-sn#2471) * Reading in decay radiation data in atom data * Added docstring * Fixes the checksum * Pre-release 2023.11.26 (tardis-sn#2477) Automated changes for pre-release 2023.11.26 * Update plasma configuration documentation (tardis-sn#2459) * update plasma docs * Update mailmap * Fix typo * Add ruff rules and docs (tardis-sn#2478) * Add ruff rules and docs * Update pyproject.toml Co-authored-by: Wolfgang Kerzendorf <[email protected]> * rebuild docs --------- Co-authored-by: Wolfgang Kerzendorf <[email protected]> * Decay energy chain (tardis-sn#2448) * Added a function to calculate shell masses * Added a function to calculate shell masses * changed shell masses with the new function * Changed mass fraction to masses in to_inventories() * Co-authored-by: Wolfgang Kerzendorf <[email protected]> * Added a function to calculate total decays * Added a function to calculate energies from gamma rays and positrons. * added a function to calculate average energies of gamma rays and positrons * Added a fucntion to calculate each decay chain energies * Added dictionaries to handle multiple isotopes * Changed value to values * added tests for gamma_ray_transport * Added tests for calculating activity * Added test for activity * Added tests for two isotope * Changed Ni_isotope_mass * Added pytest paramterize * Added test for calculating shell masses * Ran test for checking activity of parent nuclide with analytical solution. * The function test_activity matches with the radioactivedecay output upto 14 decimal places. The Avogadro's number used in radioactivedecay is not from astropy. * Added tests for checking if iso_dict is returning the right key. * Added test for inventories dictionary. * Added a test to check if the calculate_average_energy function passes the right list ahead. * Added new function for testing energy budget from each decay chain. * Added a new function for energy per mass * Reading in decay radiation data in atom data * Add * Added tests for gamma ray transport. * Added tests for all functions for gamma_ray_transport. Added docstrings. * Changing decay energy chain * Added a function to get taus * Added tests for multiple isotopes * Fixes the test calculate shell masses with hand calculated values * Use Mamba instead of conda * Run asv for last 5 commits * Add pull request trigger temporarily * Reset --------- Co-authored-by: tardis-bot <[email protected]> Co-authored-by: Wolfgang Kerzendorf <[email protected]> Co-authored-by: Anirban <[email protected]> Co-authored-by: Alexander Holas <[email protected]> Co-authored-by: Alexander Holas <alexander.holas@h-its> Co-authored-by: Joshua Shields <[email protected]> Co-authored-by: Anirban <[email protected]> Co-authored-by: Christian Vogl <[email protected]> Co-authored-by: Andrew <[email protected]>

Install latest version of mamba

8925a48

atharva-2001 requested review from andrewfullard and epassaro October 6, 2023 12:56

atharva-2001 added CI/CD infrastructure labels Oct 6, 2023

Unpin conda lock installatiion

1ae1731

atharva-2001 marked this pull request as ready for review October 6, 2023 13:07

Split lockfilee creation to separate workflow

4c8d8f4

andrewfullard previously approved these changes Oct 6, 2023

View reviewed changes

change docs installation- put a warning for conda forge installation …

e7dcb90

…and comment out install from package

atharva-2001 dismissed andrewfullard’s stale review via e7dcb90 October 9, 2023 10:51

atharva-2001 added the build-docs label Oct 9, 2023

fix

b85c39c

andrewfullard previously approved these changes Oct 9, 2023

View reviewed changes

delete create lockfiles

d498abc

atharva-2001 dismissed andrewfullard’s stale review via d498abc October 17, 2023 11:15

download llock file

a048ff6

andrewfullard self-requested a review October 17, 2023 13:20

andrewfullard approved these changes Oct 17, 2023

View reviewed changes

atharva-2001 changed the title ~~Create Lock Files With Latest Versions of Mamba~~ Remove lock file creation from pre release workflow Oct 17, 2023

atharva-2001 requested a review from DeerWhale October 18, 2023 04:49

andrewfullard merged commit 4b7d92f into tardis-sn:master Oct 20, 2023
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove lock file creation from pre release workflow #2432

Remove lock file creation from pre release workflow #2432

atharva-2001 commented Oct 6, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023 •

edited

Loading

andrewfullard left a comment

atharva-2001 commented Oct 6, 2023

atharva-2001 commented Oct 9, 2023

tardis-bot commented Oct 9, 2023 •

edited

Loading

wkerzendorf commented Oct 10, 2023

andrewfullard commented Oct 17, 2023

atharva-2001 commented Oct 17, 2023

Remove lock file creation from pre release workflow #2432

Remove lock file creation from pre release workflow #2432

Conversation

atharva-2001 commented Oct 6, 2023 • edited Loading

📝 Description

📌 Resources

🚦 Testing

☑️ Checklist

codecov bot commented Oct 6, 2023 • edited Loading

Codecov Report

andrewfullard left a comment

Choose a reason for hiding this comment

atharva-2001 commented Oct 6, 2023

atharva-2001 commented Oct 9, 2023

tardis-bot commented Oct 9, 2023 • edited Loading

wkerzendorf commented Oct 10, 2023

andrewfullard commented Oct 17, 2023

atharva-2001 commented Oct 17, 2023

atharva-2001 commented Oct 6, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023 •

edited

Loading

tardis-bot commented Oct 9, 2023 •

edited

Loading