Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Tardis CSV input for custom abundances and isotopes #830

Closed
unoebauer opened this issue Jun 18, 2018 · 1 comment
Closed

Using Tardis CSV input for custom abundances and isotopes #830

unoebauer opened this issue Jun 18, 2018 · 1 comment

Comments

@unoebauer
Copy link
Contributor

unoebauer commented Jun 18, 2018

While working with the CSV input option for custom abundance and isotope profiles, I noticed that the relevant parser in model_reader.py,

def read_simple_isotope_abundances(fname, delimiter='\s+'):

expects that the custom composition file contains information about the ejecta state (velocity, temperature, electron density, ...) in the first four columns.

I assume that this was at some point implemented to work with CMFGEN setups (right @wkerzendorf?), but for most normal use cases these columns are irrelevant. Either the information is not used or specified in the model density profile setup process. In any case, the current documentation does not specify that when using CSV files, four additional columns are needed.

I would suggest that we split the CSV input option into two use cases

  • CMFGEN setups, for which keep the current parser
  • normal Tardis use cases: for this we should add an additional parser (based on the current one) which does not expect additional ejecta information in the first four columns

In any case, the documentation should be updated to reflect the behaviour of the CSV parser

@wkerzendorf
Copy link
Member

I agree - I'm trying to figure out what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants