Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for virtual spectrum required #447

Closed
unoebauer opened this issue Dec 1, 2015 · 0 comments · Fixed by #449
Closed

Test for virtual spectrum required #447

unoebauer opened this issue Dec 1, 2015 · 0 comments · Fixed by #449

Comments

@unoebauer
Copy link
Contributor

Issue #445 clearly demonstrated that we need to test explicitly the correct determination of the virtual spectrum. We could simply add a test_virtual_spectrum method to test_tardis_full.py, which does essentially the same as test_spectrum but for the virtual spectrum.

This would imply that we do another bitwise spectral comparison. I guess this is our best option until the statistics project has matured enough....Other ideas, @orbitfold, @wkerzendorf, @ssim, @chvogl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant