Montecarlo Packet Progress bar does not go to 100%

[Rodot-]

Describe the bug
When running the montecarlo main loop, the progress bar updates with an approximation for the number of packets completed when run in multithreaded mode. At the end of the loop, the progress bar is no longer updated so the display never shows it reaching 100%.

To solve this problem, at the end of the loop another update call to the progress bar should be made to fill out the remaining progress.

To Reproduce
Run a tardis model with >=2 threads

System

• OS:

  • GNU/Linux
  • macOS

• Environment (conda list):

Additional context

[AyushiDaksh]

@Rodot- Are you still working on this? If not, can I pick it up?

[Rodot-]

I'm not working on this myself so it is definitely up for grabs

[shreyas3156]

@Rodot- There seems to be a delay of a few seconds (even after the particular cell in the notebook has finished running), after which the packet progress bar does update to 100%. I could reproduce this for 1 <= no. of threads <= 4.

[shreyas3156]

Hi @Rodot- I have made a PR that aims to solve this issue. It would be great if you could review it.

[atharva-2001]

@Rodot- Does PR #2237 fix this issue?

[MarkMageeAstro]

Seems to be fixed now