You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
As part of #1170, creating separate issue for discussion specific to the pre-commit.
Describe the solution you'd like
Add pre-commit hook that will run Black + other tools of choice. Black definitely will be there as it's already in the GH check and recommended in tardis docs, what else should be used?
which means that config should be updated from time to time.
How to do that?
"Dumb" solution: add a workflow that runs pre-commit autoupdate weekly and commits changes.
Maybe an "easier" solution: use pre-commit.ci. It will update pre-commit config every week AND it will check all PRs and fix them. This will even allow to remove the existing Black check from GitHub Actions (at least for PRs). They say it is free for open source repositories but paid for "organization" repositories. I suppose tardis-sn is the former?
If we don't use pre-commit.ci, we'll also need to add isort+linter checks to GitHub Actions manually.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
As part of #1170, creating separate issue for discussion specific to the pre-commit.
Describe the solution you'd like
Add pre-commit hook that will run Black + other tools of choice. Black definitely will be there as it's already in the GH check and recommended in tardis docs, what else should be used?
isort seems like a good idea.
flake8 will require more configuration but also can be added.
Describe alternatives you've considered
Everyone writes however they want and PRs get messier from "blackify" commits more often. Anarchy.
Additional context
I think this should be a staggered approach:
isort
, will need to add config as well.pre-commit
requires to pin to rev, like this:which means that config should be updated from time to time.
How to do that?
"Dumb" solution: add a workflow that runs
pre-commit autoupdate
weekly and commits changes.Maybe an "easier" solution: use pre-commit.ci. It will update pre-commit config every week AND it will check all PRs and fix them. This will even allow to remove the existing Black check from GitHub Actions (at least for PRs). They say it is free for open source repositories but paid for "organization" repositories. I suppose tardis-sn is the former?
If we don't use pre-commit.ci, we'll also need to add isort+linter checks to GitHub Actions manually.
The text was updated successfully, but these errors were encountered: