Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Procedure for Addition of New Dependecies to TARDIS #1563

Open
Rodot- opened this issue May 11, 2021 · 0 comments
Open

Procedure for Addition of New Dependecies to TARDIS #1563

Rodot- opened this issue May 11, 2021 · 0 comments

Comments

@Rodot-
Copy link
Contributor

Rodot- commented May 11, 2021

Is your feature request related to a problem? Please describe.

Addition of new dependencies to TARDIS comes with the risk of introducing potential long-term instability. To mitigate this, we present a procedure for the review of pull requests which introduce new dependencies to TARDIS.

Describe the solution you'd like

  • Addition of new dependencies to TARDIS should be done through a pull request whose only change is the addition of the new package in the TARDIS environment file.
  • 4 reviewers must approve of said pull request
    • At least 3 reviewers must be members of the TARDIS Core Team
    • At least 1 reviewer must be a TARDIS contributor who has made recent contributions to components of TARDIS that this dependency addition would affect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants