Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis Labels Not Parsing Correctly in SDEC Plot via Plotly #1485

Closed
DhruvSondhi opened this issue Mar 16, 2021 · 4 comments · Fixed by #1531
Closed

Axis Labels Not Parsing Correctly in SDEC Plot via Plotly #1485

DhruvSondhi opened this issue Mar 16, 2021 · 4 comments · Fixed by #1531

Comments

@DhruvSondhi
Copy link
Contributor

Problem description

The axis labels in SDEC plots made with plotly are not being parsed correctly. This can be seen in the docs here.
Attaching screenshot as applicable:
image
I ran the notebook & the example on my local machine & it was working as intended ... I think we need to re-run the notebooks in docs to check if this is a problem for the parsing or native function definition problem.

Expected Output

The axis needs to be parsed correctly as shown :
image

Please confirm the same & hence if it is a problem I would like to help in fixing it 😄

@andrewfullard
Copy link
Contributor

This is definitely an issue and should be fixed!

@DhruvSondhi
Copy link
Contributor Author

Hello @andrewfullard, I can re-run the notebook on my local environment & generate the output that way ... After that I can commit the changes for the notebook directly 😄

@jaladh-singhal
Copy link
Member

Hello @andrewfullard, I can re-run the notebook on my local environment & generate the output that way ... After that I can commit the changes for the notebook directly

@DhruvSondhi go ahead and make a PR

@DhruvSondhi
Copy link
Contributor Author

DhruvSondhi commented Apr 9, 2021

Hey @jaladh-singhal ... Where can I find the demo.hdf data for hdf_plotter here? 🤔
I found this but I am not sure that the simulation data stored in the demo.hdf may be same as those produced through the tardis_example.yml Tardis run()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants