Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need formal integral test for C code to compare new Numba code to #1448

Closed
andrewfullard opened this issue Feb 4, 2021 · 4 comments
Closed

Comments

@andrewfullard
Copy link
Contributor

This needs to almost certainly be the formal integral output from a standard TARDIS input file. Then we can run a residuals comparison with the Numba version to make sure it's close enough (where close enough is probably less than 1% difference in results)

@andrewfullard
Copy link
Contributor Author

This needs to become part of the refdata as well, probably

@karban8
Copy link

karban8 commented Mar 20, 2021

Hi, I would like to work on this issue. What I infer from the description is that I need to plot the spectrum using formal integral method as given here and compare the results obtained by running the new numba code. Also the results must be within 1% variation. Please guide me further

@andrewfullard
Copy link
Contributor Author

That is one possibility. It is currently accomplished in the workflow here: https://github.com/tardis-sn/tardis/blob/master/azure-pipelines/compare-refdata.yml (you can see a result here #1467 )

The other method is to follow #1499 and work with @aribalam regarding it.

@andrewfullard
Copy link
Contributor Author

This has been at least partially fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants