Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect data types for real packet logging output data #1389

Closed
andrewfullard opened this issue Dec 15, 2020 · 2 comments · Fixed by #1420
Closed

Incorrect data types for real packet logging output data #1389

andrewfullard opened this issue Dec 15, 2020 · 2 comments · Fixed by #1420

Comments

@andrewfullard
Copy link
Contributor

Problem description

last_interaction_type , last_line_interaction_in_id and last_line_interaction_out_id are saved as float in sim.runner whereas corresponding properties for virtual packets are saved as int which is the expected type.

Expected Output

Save them as int

@DhruvSondhi
Copy link
Contributor

DhruvSondhi commented Jan 2, 2021

Hello, Can you shed some more light upon this issue? Where can I find the required function?
I found this virtual packets variable in 2-3 files but was not able to pinpoint the location where this bug is arising from. 🤔

@andrewfullard
Copy link
Contributor Author

I think it most likely arises in montecarlo_main_loop in tardis/montecarlo/montecarlo_numba/base.py where the arrays are defined to pass through to the sim.runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants