Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config parser should verify that parameters are physically realistic #1343

Closed
Rodot- opened this issue Nov 13, 2020 · 2 comments
Closed

Config parser should verify that parameters are physically realistic #1343

Rodot- opened this issue Nov 13, 2020 · 2 comments

Comments

@Rodot-
Copy link
Contributor

Rodot- commented Nov 13, 2020

Problem description

tardis will currently run when given negative abundances without complaining. Other physically unrealistic parameters like negative densities are also run without complaint resulting in odd behavior of TARDIS (freezing up for example). We should implement some sort of checks in the config parsers (or when we run tardis) to make sure that the config represents a physically realistic system

@aribalam
Copy link
Contributor

@Rodot- Would like to take this up. Could you point me in the right direction?

@DhruvSondhi
Copy link
Contributor

@andrewfullard this issue can be closed !!

@Rodot- Rodot- closed this as completed May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants