From 5f4dc2a358388656108d0cb39dd60aba3aa185b4 Mon Sep 17 00:00:00 2001 From: Asish Kumar Date: Wed, 31 Jul 2024 17:37:22 +0530 Subject: [PATCH 1/5] titanic Signed-off-by: Asish Kumar --- .github/workflows/benchmarks.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 9ed9b5581e4..03c0d808b09 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -29,11 +29,6 @@ defaults: jobs: build: - if: github.repository_owner == 'tardis-sn' && - (github.event_name == 'push' || - github.event_name == 'workflow_dispatch' || - (github.event_name == 'pull_request_target' && - contains(github.event.pull_request.labels.*.name, 'benchmarks'))) runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -75,8 +70,8 @@ jobs: - name: Run benchmarks for last 5 commits if not PR if: github.event_name != 'pull_request_target' run: | - git log -n 4 --pretty=format:"%H" >> tag_commits.txt - asv run -a repeat=1 -a rounds=1 HASHFILE:tag_commits.txt | tee asv-output.log + git log -n 4 --pretty=format:"%H" >> tag_commits.txt + asv run HASHFILE:tag_commits.txt | tee asv-output.log if grep -q failed asv-output.log; then echo "Some benchmarks have failed!" exit 1 From 08113e3505d4910811292b5f11850c5adf0b1476 Mon Sep 17 00:00:00 2001 From: Asish Kumar Date: Wed, 31 Jul 2024 17:39:37 +0530 Subject: [PATCH 2/5] can we skip to the good part? Signed-off-by: Asish Kumar --- .github/workflows/benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 03c0d808b09..4c8461b1787 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -70,7 +70,7 @@ jobs: - name: Run benchmarks for last 5 commits if not PR if: github.event_name != 'pull_request_target' run: | - git log -n 4 --pretty=format:"%H" >> tag_commits.txt + git log -n 1 --pretty=format:"%H" >> tag_commits.txt asv run HASHFILE:tag_commits.txt | tee asv-output.log if grep -q failed asv-output.log; then echo "Some benchmarks have failed!" From 70e6391239ca2553c8fe6fd6fe0600767a3d2a2e Mon Sep 17 00:00:00 2001 From: Asish Kumar Date: Wed, 31 Jul 2024 22:43:02 +0530 Subject: [PATCH 3/5] commit 1 Signed-off-by: Asish Kumar --- .github/workflows/benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 4c8461b1787..18636f02f68 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -73,7 +73,7 @@ jobs: git log -n 1 --pretty=format:"%H" >> tag_commits.txt asv run HASHFILE:tag_commits.txt | tee asv-output.log if grep -q failed asv-output.log; then - echo "Some benchmarks have failed!" + echo "Some benchmarks have failed!" exit 1 fi From 12a512cd3ea3a1c268aa0a36e2e2097104945c55 Mon Sep 17 00:00:00 2001 From: Asish Kumar Date: Wed, 31 Jul 2024 22:43:16 +0530 Subject: [PATCH 4/5] commit 2 Signed-off-by: Asish Kumar --- .github/workflows/benchmarks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 18636f02f68..baf5564fad7 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -73,7 +73,7 @@ jobs: git log -n 1 --pretty=format:"%H" >> tag_commits.txt asv run HASHFILE:tag_commits.txt | tee asv-output.log if grep -q failed asv-output.log; then - echo "Some benchmarks have failed!" + echo "Some benchmarks have failed!" exit 1 fi From 9934b20b441d7488cb59411c650ba24e69dd011d Mon Sep 17 00:00:00 2001 From: Asish Kumar Date: Wed, 31 Jul 2024 22:44:07 +0530 Subject: [PATCH 5/5] well well well Signed-off-by: Asish Kumar --- .github/workflows/benchmarks.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index baf5564fad7..4c95ef213b0 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -67,13 +67,13 @@ jobs: - name: Accept all asv questions run: asv machine --yes - - name: Run benchmarks for last 5 commits if not PR + - name: Run benchmarks for last 4 commits if not PR if: github.event_name != 'pull_request_target' run: | - git log -n 1 --pretty=format:"%H" >> tag_commits.txt + git log -n 4 --pretty=format:"%H" >> tag_commits.txt asv run HASHFILE:tag_commits.txt | tee asv-output.log if grep -q failed asv-output.log; then - echo "Some benchmarks have failed!" + echo "Some benchmarks have failed!" exit 1 fi