Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that the centralized configuration cannot contain the 'config.etcd' and 'config.storage' sections #4190

Closed
Tracked by #4294
andreyaksenov opened this issue May 13, 2024 · 2 comments · Fixed by #4456
Closed
Tracked by #4294

Clarify that the centralized configuration cannot contain the 'config.etcd' and 'config.storage' sections #4190

andreyaksenov opened this issue May 13, 2024 · 2 comments · Fixed by #4456
Assignees
@andreyaksenov
Labels
3.0 config

Comments

@andreyaksenov
Copy link
Contributor

andreyaksenov commented May 13, 2024 •
edited
Loading

Product: Tarantool
Since: 3.0
Root document:

SME: @ totktonada
@andreyaksenov andreyaksenov self-assigned this May 13, 2024
@andreyaksenov andreyaksenov changed the title Clarify that the centralized configuration cannot contain the 'config' section used to get this configuration Clarify that the centralized configuration cannot contain the 'config' section May 13, 2024
@andreyaksenov andreyaksenov removed their assignment May 14, 2024
This was referenced Jun 10, 2024
Open
Closed
Open
@andreyaksenov andreyaksenov self-assigned this Aug 15, 2024
@andreyaksenov andreyaksenov linked a pull request Aug 16, 2024 that will close this issue
Fix config feedback #4456
Merged
@andreyaksenov andreyaksenov mentioned this issue Aug 16, 2024
Merged
@Totktonada
Copy link
Member

The title is a bit misleading. It is OK to have config.context in the centralized configuration storage. However, that's true that config.etcd and config.storage in the centrilized storage have no much sense.

See also https://github.com/tarantool/tarantool-ee/issues/644, where the actual check was implemented.

@andreyaksenov
Copy link
Contributor Author

andreyaksenov commented Aug 19, 2024 •
edited
Loading

The title is a bit misleading. It is OK to have config.context in the centralized configuration storage.

Totally agree. Created the issue before understanding the full context. Will fix.

@andreyaksenov andreyaksenov changed the title Clarify that the centralized configuration cannot contain the 'config' section Clarify that the centralized configuration cannot contain the 'config.etcd' and 'config.storage' sections Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreyaksenov andreyaksenov

Labels
3.0 config
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix config feedback tarantool/doc
2 participants
@Totktonada @andreyaksenov