-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tape-run emitting an HTML file in root #58
Comments
i should have fixed this in electron-stream (a dependency), can you update your tape-run and tell me if this still happens? |
perfect, works great! just curious, I see that it still makes the temporary file (and then immediately deletes it). did it always do that or did something change? |
@juliangruber also, it seems that the file doesn't get deleted if the tests fail |
You're right that this behavior is new. I needed to add those in order to add
Oh, I'll look into it. |
if you reinstall browser-run, and so get the latest electron-stream as well, this shouldn't be an issue any more. Tested with $ ./node_modules/.bin/browserify test/fixtures/fail.js | ./bin/run.js |
@juliangruber thanks for the fast turn-around! |
Hey there, I've just installed a project of my own that was previously working with no problem running I have the same issue as raised by @davelandry where tape-run creates a file like This problem only occurs with electron, however I have to hack browser-run to use browser-launcher2 if I want to run tests in anything other than electron. eg: \node_modules\browser-run\lib\launch.js
- var launcher = require('browser-launcher');
+ var launcher = require('browser-launcher2'); TL;DR that's another nuisance issue I won't go into detail about here. My Environment: [email protected] Example of my test runner task: gulp.task('js:test', ['js:lint'], () => {
browserify('./src/tests.js')
.transform('rollupify', {
plugins: [nodeResolve, rollCommon]
})
.transform(babelify.configure({
presets: ['es2015']
}))
.transform('envify', {
PROJECT_VARIABLE: ''
})
.bundle()
.on('error', function (err) {
utility.errorHandler(err, this);
this.emit('end');
})
.pipe(plumber({ errorHandler: utility.errorHandler }))
.pipe(tapeRun())
.pipe(tapSpec())
.pipe(process.stdout);
}); Resulting Error:
References: This issue has stopped me dead in my tracks as rolling back seems to have no effect and I'm uncertain as to why, even starting from scratch with a purpose built test case and attempting to maintain the original I should note also that the last working configuration was: |
I've finally rolled out a patch for electron-stream that makes it use the Does this fix your problem? For the |
Legend, this now works as expected (I assume you meant electron-stream? Which is now @5.0.3). As for the Thanks for the quick response. |
Thanks for such a great package! Just upgraded to v3, and whenever I run my tests it produces a file in my root directory that looks like this:
Which contains the compiled code with the HTML wrap. Here is the command that I'm running:
Tests run/exit correctly, but is there any way to not create this file? For now I can just remove them manually (new one is created with the current Date timestamp on each run).
The text was updated successfully, but these errors were encountered: