Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification of caching behavior #3102

Closed
wants to merge 1 commit into from
Closed

Clarification of caching behavior #3102

wants to merge 1 commit into from

Conversation

aryzing
Copy link
Contributor

@aryzing aryzing commented Dec 16, 2021

The example contains at least one inacurate statement,

It will then cache the data using 'todos' and fetchTodos as the unique identifiers for that cache.

and could benefit from more precise language.

@vercel
Copy link

vercel bot commented Dec 16, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tanstack/react-query/6iZQE8V4izV4NKkmpLgA6haq9T9s
✅ Preview: https://react-query-git-fork-aryzing-patch-1-tanstack.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 16, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94b5c85:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration

@TkDodo
Copy link
Collaborator

TkDodo commented Dec 23, 2021

could you maybe port this to the v4 docs (base on the alpha branch)? I remember updating that section because the querykeys need to be an array in v4.

TkDodo
TkDodo reviewed Jan 21, 2022
View reviewed changes
docs/src/pages/guides/caching.md Outdated Show resolved Hide resolved
docs/src/pages/guides/caching.md Outdated Show resolved Hide resolved
@aryzing
docs: clarify caching behavior
94b5c85 
The example contains at least one inacurate statement,

> It will then cache the data using `'todos'` and `fetchTodos` as the unique identifiers for that cache.

and could benefit from more precise language.
@aryzing
Copy link
Contributor Author

aryzing commented Jan 21, 2022

Corrected suggestions and rebased on alpha branch as requested, new PR here: #3221

@aryzing aryzing closed this Jan 21, 2022
@aryzing aryzing mentioned this pull request Jan 21, 2022
Merged
@aryzing aryzing deleted the patch-1 branch January 23, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo TkDodo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryzing @TkDodo