fix: cache select errors #3554
fix: cache select errors #3554
Conversation
there is no need to re-run the select function if it is referentially stable, even when it throws an error. if no dependency has changed, we can re-use the cached error, as the select function should be idempotent and thus return the same error anyway. further, if we have cached data from a previously successful select, that should be returned as `data` alongside the error.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d1bcef:
|
Codecov Report
@@ Coverage Diff @@
## master #3554 +/- ##
==========================================
- Coverage 96.35% 96.35% -0.01%
==========================================
Files 45 45
Lines 2278 2277 -1
Branches 637 637
==========================================
- Hits 2195 2194 -1
Misses 80 80
Partials 3 3
Continue to review full report at Codecov.
|
|
working forked sandbox from the discussion with the preview build: https://codesandbox.io/s/error-logging-forked-jp52dv?file=/src/App.jsx |
|
🎉 This PR is included in version 3.38.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
there is no need to re-run the select function if it is referentially stable, even when it throws an error. if no dependency has changed, we can re-use the cached error, as the select function should be idempotent and thus return the same error anyway. further, if we have cached data from a previously successful select, that should be returned as `data` alongside the error.
|
🎉 This PR is included in version 4.0.0-beta.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
refs #3530
there is no need to re-run the select function if it is referentially stable, even when it throws an error. if no dependency has changed, we can re-use the cached error, as the select function should be idempotent and thus return the same error anyway.
further, if we have cached data from a previously successful select, that should be returned as
dataalongside the error.