fix(queryObserver): memoized select functions should not return outdated values #3140
Conversation
…ted values not all runs to createResult are saved on `this.currentResult` (optimistically created updates do not - we just create the result again later). With the fix from TanStack#3098, we made sure that memoized select does not run again in those cases by storing every run. However, that now means that we cannot rely on `prevResult.data` because it might still contain outdated data. The solution is to store a pair of previous selectFn + data and return the exact data that was computed from the previous select fn if we get the exact same function passed
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tanstack/react-query/BManugcg3QoE79N4YwKSowuFEZ38 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d372e06:
|
Codecov Report
@@ Coverage Diff @@
## master #3140 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 45 45
Lines 2270 2270
Branches 639 639
=======================================
Hits 2190 2190
Misses 77 77
Partials 3 3
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 3.34.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
not all runs to createResult are saved on
this.currentResult(optimistically created updates do not - we just create the result again later). With the fix from #3098, we made sure that memoized select does not run again in those cases by storing every run. However, that now means that we cannot rely onprevResult.databecause it might still contain outdated data.The solution is to store a pair of previous selectFn + data and return the exact data that was computed from the previous select fn if we get the exact same function passed
closes #3139