Feat/theme-photo #2921
Merged
Feat/theme-photo #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (item.querySelector('figcaption').textContent.trim() === value) { | ||
| item.classList.add('active') | ||
| if (iframe) { | ||
| iframe.setAttribute('src', iframe.getAttribute('data-src')) |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 25 days ago
To fix the problem, we need to ensure that the value retrieved from the data-src attribute is properly sanitized before being used as the src attribute of the iframe. One way to do this is to use a library like DOMPurify to sanitize the value. This will help prevent any malicious content from being executed.
- Import the DOMPurify library.
- Use DOMPurify to sanitize the value retrieved from the
data-srcattribute before setting it as thesrcattribute of theiframe.
Suggested changeset
2
themes/photo/index.js
| @@ -34,2 +34,3 @@ | ||
| import { Style } from './style' | ||
| import DOMPurify from 'dompurify' | ||
|
|
||
| @@ -244,3 +245,3 @@ | ||
| if (iframe) { | ||
| iframe.setAttribute('src', iframe.getAttribute('data-src')) | ||
| iframe.setAttribute('src', DOMPurify.sanitize(iframe.getAttribute('data-src'))) | ||
| } |
package.json
Outside changed files
| @@ -44,3 +44,4 @@ | ||
| "react-share": "^4.4.1", | ||
| "react-tweet-embed": "~2.0.0" | ||
| "react-tweet-embed": "~2.0.0", | ||
| "dompurify": "^3.1.7" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| dompurify (npm) | 3.1.7 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Deploying notionnext with
|
| Latest commit: |
2ccaf6b
|
| Status: | ⚡️ Build in progress... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
一个图册的主题