Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLastRunTime() needs pagination - not working for projects with lots of pipelines #12

Open
MaxWinterstein opened this issue Dec 20, 2022 · 1 comment

Comments

@MaxWinterstein
Copy link

MaxWinterstein commented Dec 20, 2022

As getLastRunTime() only fetches the default number of pipelines, which is 20 as of today, it thinks it never ran.

As we use a monorepo for all CI stuff getting more than 20 pipelines between the daily run of this fantastic tool, we sometimes get duplicated issues.

Adding ListOptions does at least an enhancement to 100 pipelines, but maybe a configurable parameter, and pagination would be an awesome benefit at this.

		ListOptions: gitlab.ListOptions{
			PerPage: 100,
			Page:    1,
		},

Pagination example: https://github.com/xanzy/go-gitlab/blob/master/examples/pagination.go

@tamslo
Copy link
Owner

tamslo commented Sep 12, 2023

Hi, thank you for pointing this out! I am not really able to implement a lot for this project currently, but please feel free to create a pull request or fork your own version! 😊

Happy this small tool is/was also useful for others! 🙏 And sorry for not answering for so long, I am not really working on this other than for my own small projects 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants