Skip to content

Commit

Permalink
fix: update sidero IPMI user to work properly on idrac
Browse files Browse the repository at this point in the history
This PR makes sure that the sidero user gets the `callin=true` access.
Setting this for these sidero users seems to function just fine on tests of both
iDrac and ASROCK BMCs.

Signed-off-by: Spencer Smith <[email protected]>
  • Loading branch information
rsmitty authored and talos-bot committed Aug 4, 2021
1 parent acd82e0 commit 7bdee0f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/sidero-controller-manager/cmd/agent/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,10 @@ func attemptBMCUserSetup(ctx context.Context, client api.AgentClient, s *smbios.
}

// Make sidero an admin
// Options: 0xD1 == Callin false, Link false, IPMI Msg true, Channel 1
// Options: 0x91 == Callin true, Link false, IPMI Msg true, Channel 1
// Limits: 0x03 == Administrator
// Session: 0x00 No session limit
_, err = ipmiClient.SetUserAccess(0xD1, sideroUserID, 0x04, 0x00)
_, err = ipmiClient.SetUserAccess(0x91, sideroUserID, 0x04, 0x00)
if err != nil {
return err
}
Expand Down

0 comments on commit 7bdee0f

Please sign in to comment.